How to click one of the elements in a list through javascript to get the dataset-CodePudding

I have a set of lists, and each block of the list has a data-id set. I hope to get the data-id of the clicked block when the block is clicked. However, I am not familiar with javascript yet, so I don’t know how to get it correctly. I hope you can help me, thank you.

let wrap = document.querySelector('.wrap');
let item = wrap.querySelectorAll('.notice_item');

for (let i = 0; i < item.length; i  ) {
  item[i].onclick = function(e) {
    console.log(e.target.dataset.id)
  }
}

.wrap {
  display: flex;
  flex-direction: column;
}

.wrap li {
  padding: 16px;
}

.wrap li:hover {
  background-color: yellow;
}

.wrap li .info_title {
  font-size: 20px;
  color: #222;
}

.wrap li .info_main {
  font-size: 14px;
  color: #222;
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<ul >
  <li>
    <a  href="javascript:;" data-id="111">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
  <li>
    <a  href="javascript:;" data-id="222">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
  <li>
    <a  href="javascript:;" data-id="333">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
</ul>

CodePudding user response：

This situation is better suited for the use of event delegation.

By the way, don't use inline javascript: for hrefs (or inline handling for that matter).

document.addEventListener(`click`, handle);

function handle(evt) {
  const checkNotice = evt.target.closest(`.notice_item`);
  if (checkNotice) {
    console.clear();
    console.log(checkNotice.dataset.id);
  }
}

.wrap {
  display: flex;
  flex-direction: column;
}

.wrap li {
  padding: 16px;
}

.wrap li:hover {
  background-color: yellow;
}

.wrap li .info_title {
  font-size: 20px;
  color: #222;
}

.wrap li .info_main {
  font-size: 14px;
  color: #222;
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<ul >
  <li>
    <a  href="#" data-id="111">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
  <li>
    <a  href="#" data-id="222">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
  <li>
    <a  href="#" data-id="333">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
</ul>

CodePudding user response：

I've modified a little your html removing the a tag. i've add the listener to every div with class .notice_content ang get it's data-id on click

let wrap = document.querySelectorAll('.notice_content');

wrap.forEach(item => {
  item.addEventListener("click", function(){
    console.log(item.dataset.id)
  })
 })

.wrap {
  display: flex;
  flex-direction: column;
}

.wrap li {
  padding: 16px;
}

.wrap li:hover {
  background-color: yellow;
}

.wrap li .info_title {
  font-size: 20px;
  color: #222;
}

.wrap li .info_main {
  font-size: 14px;
  color: #222;
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<ul >
  <li>
      <div  data-id="111">
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
  </li>
  <li>
      <div   data-id="222">
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
  </li>
  <li>
      <div  data-id="333">
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
  </li>
</ul>

CodePudding user response：

You were very close. Check the code below. hope this helps.

let wrap = document.querySelector('.wrap');
let item = wrap.querySelectorAll('.notice_item');

for (let i = 0; i < item.length; i  ) {
  item[i].onclick = function(e) {
    console.log(e.currentTarget.dataset.id);
  }
}

.wrap {
  display: flex;
  flex-direction: column;
}

.wrap li {
  padding: 16px;
}

.wrap li:hover {
  background-color: yellow;
}

.wrap li .info_title {
  font-size: 20px;
  color: #222;
}

.wrap li .info_main {
  font-size: 14px;
  color: #222;
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<ul >
  <li>
    <a  href="javascript:;" data-id="111">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
  <li>
    <a  href="javascript:;" data-id="222">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
  <li>
    <a  href="javascript:;" data-id="333">
      <div >
        <h3 >TITLE</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
    </a>
  </li>
</ul>

CodePudding user response：

Here is the jQuery solution:

access dataset.id with .data('id')
access any child element with .find(), such as .find('.info_title').text()

Note that often you do not need an ID in each list element because you can access what you need from the DOM. You can find a child element with .find('.someClass'), traverse one element up with .parent(), find an element several levels up with .closest('.someClass').

$(function() {
   $('.notice_content').click(function() {
     let id = $(this).data('id');
     let title = $(this).find('.info_title').text();
     console.log('click on:', { id, title });
   });
 });

.wrap {
  display: flex;
  flex-direction: column;
}
.wrap li {
  padding: 16px;
}
.wrap li:hover {
  background-color: yellow;
}
.wrap li .info_title {
  font-size: 20px;
  color: #222;
}
.wrap li .info_main {
  font-size: 14px;
  color: #222;
}

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<ul >
  <li>
      <div  data-id="111">
        <h3 >TITLE 111</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
  </li>
  <li>
      <div   data-id="222">
        <h3 >TITLE 222</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
  </li>
  <li>
      <div  data-id="333">
        <h3 >TITLE 333</h3>
        <p >Lorem ipsum dolor sit amet, consectetur adipisicing elit. In labore assumenda perspiciatis illum quo corrupti, magnam ratione fuga omnis enim!</p>
      </div>
  </li>
</ul>