I wrote the following code to solve the readability lab. It is compiling well with no problem. The problem is in the results, as for an unknown reason it always calculates s_avg as zero. s_avg is the average number of sentences in 100 words.

#include <ctype.h>
#include <cs50.h>
#include <stdio.h>
#include <string.h>
#include <math.h>

//prototypes
int count_letters (string text);
int count_words(string text);
int count_sent(string text);

int main(void)
{
    // get the user to prompt part of the story
    string story = get_string("Text: \n");
    
    //variables
    int letters = count_letters(story);
    int words = count_words(story);
    int sentences = count_sent(story);
    
    //show results
    printf("%i letter(s)\n",letters);
    printf("%i word(s)\n",words);
    printf("%i sentence(s)\n",sentences);
    
    // Calculate average number of letters & sentences per 100 words
    int l_avg = (letters/words)*100;
    int s_avg = (sentences/words)*100;
    
    // Calculate Coleman-Liau index
    int index = round(0.0588 * l_avg - 0.296 * s_avg - 15.8);
    
    // check grade level
    if(index<1)
    {
        printf("Before Grade 1\n");
    }
    else if(index>16)
    {
        printf("Grade 16 \n");
    }
    else
    {
        printf("Grade %i\n",index);
    }
}

//count the number of letters
int count_letters (string text)
{
    int l = 0;
    for(int i=0,n=strlen(text); i<n; i  )
    {

        if((text[i]>=97 && text[i]<=122)||(text[i]>=65 && text[i]<=90))
        {

            l   ;
        }
    }
    return l;
}

//count the number of words
int count_words(string text)
{
    int w = 1;
    for(int i=0,n=strlen(text); i<n; i  )
    {
        if (text[i]==32)
        {
            w   ;
        }
    }
    return w ;
}

//count the number of sentences
int count_sent(string text)
{
    int s=0;
    for(int i=0,n=strlen(text); i<n; i  )
    {
        if ((text[i]==46) || (text[i]==33) || (text[i]==63))
        {
            s   ;
        }
    }
    return s;
}

I don't know why it keeps calculating int s_avg = (sentences/words)*100; as zero. I realized that using the debug50 tool.

CodePudding user response：

For calculating average number of letters & sentences, use double type variables instead.

double l_avg = ((double)letters / (double)words)*100;
double s_avg = ((double)sentences / (double)words)*100;

CodePudding user response：

Integer division in C results in an integer, not a float. You have to explicitly cast the dividend and the divisor to float:

int i = 5 / 4;
printf("%d", i); // prints 1

float f = (float)5 / (float)4;
printf("%f", f); // prints 1.250000

So, int s_avg = (sentences/words)*100 should be:

float s_avg = (float)sentences / (float)words * 100;