I want to get the current logged in user to this CreateForm form. Below Im giving my current code, here request.user is not giving me error

ValueError at /create-post/ Cannot assign "<SimpleLazyObject: <User: testuser>>": "Post.author" must be a "Author" instance.

models.py

class Author(models.Model):
   user = models.OneToOneField(User, on_delete=models.CASCADE)
   rate = models.IntegerField(default=0)
 
class Post(models.Model):
    title = models.CharField(max_length= 50)
    overview = models.TextField()
    body_text = RichTextUploadingField(null = True)
    time_upload = models.DateTimeField(auto_now_add=True)
    author = models.ForeignKey(Author, related_name='author', on_delete=models.CASCADE)
    thumbnail = models.ImageField(upload_to = 'thumbnails')
    publish = models.BooleanField()
    categories = models.ManyToManyField(Categories)
    read = models.IntegerField(default=0)
    slug = models.SlugField(null= True, blank= True)

Forms.py

class CreateForm(ModelForm):
class Meta:
    model = Post
    fields = [
        'title',
        'overview',
        'body_text',
        'thumbnail',
        'categories',
        'publish',
    ]

Views.py

def create_post(request):
if request.method == 'POST':
    form = CreateForm(request.POST, request.FILES)
    if form.is_valid:
        post = form.save(commit=False)
        post.author= request.user
        post.save()
        return render(request, 'index.html')
else:
    form = CreateForm()
return render(request, 'create_post.html', {'form': form})

CodePudding user response：

As the error says, post.author expects an Author object, not the user. You thus retrieve this with:

from django.contrib.auth.decorators import login_required

@login_required
def create_post(request):
    if request.method == 'POST':
        form = CreateForm(request.POST, request.FILES)
        if form.is_valid():
            form.instance.author= request.user.author
            form.save()
            return render(request, 'index.html')
    else:
        form = CreateForm()
    return render(request, 'create_post.html', {'form': form})

You should also call the is_valid() method ^[Django-doc], so form.is_valid().

Note: You can limit views to a view to authenticated users with the @login_required decorator ^[Django-doc].

Note: It is normally better to make use of the settings.AUTH_USER_MODEL ^[Django-doc] to refer to the user model, than to use the User model ^[Django-doc] directly. For more information you can see the referencing the User model section of the documentation.

CodePudding user response：

The author field on your Post model is a foreign key to Author model, and not user. You could replace post.author = request.user with:

if request.user.author:
    post.author = request.user.author
else:
    post.author = Author.objects.create(user=request.user)

The answer from Willem works if an Author instance was already created for the User, but will throw an exception if there's no Author object associated with that user.