Having trouble with a AWS CloudFormation template I am trying to run. Why does this template not work?

Getting errors as follows:

The following resource(s) failed to create: [PrivateSubnet, PrivateRouteTable, InternetGatewayAttachment, DefaultPrivateRoute, WobblelandEc2Instance, VPC, PublicSubnet, WobblelandSecurityGroup, NatGateway]. Rollback requested by user.

Invalid id: "InternetGateway" (expecting "igw-...") (Service: AmazonEC2; Status Code: 400; Error Code: InvalidInternetGatewayId.Malformed; Request ID: 8d68ee2d-f68f-4c30-919d-9cab04fb5b99; Proxy: null)

The elastic-ip ID 'NatGatewayEIP.AllocationId' is malformed (Service: AmazonEC2; Status Code: 400; Error Code: InvalidElasticIpID.Malformed; Request ID: 6c371787-644b-4e0b-9e94-1ae78b9af120; Proxy: null)

Below is the template I am trying to use

AWSTemplateFormatVersion: 2010-09-09
Description: "Wumbo Jumbo"
Parameters: 
  AvailabilityZone: 
    Type: "AWS::EC2::AvailabilityZone::Name"
  EnvironmentName: 
    Description: "An environment name that is prefixed to resource names"
    Type: String
  KeyName: 
    Default: mongodb
    Type: "AWS::EC2::KeyPair::KeyName"
  PrivateSubnetCIDR: 
    Default: 10.0.2.0/24
    Description: "Please enter the IP range (CIDR notation) for the private subnet in the first Availability Zone"
    Type: String
  PublicSubnetCIDR: 
    Default: 10.0.0.0/24
    Description: "Please enter the IP range (CIDR notation) for the public subnet in the first Availability Zone"
    Type: String
  VpcCIDR: 
    Default: 10.0.0.0/16
    Description: "Please enter the IP range (CIDR notation) for this VPC"
    Type: String
Resources: 
  WobblelandEc2Instance: 
    Properties: 
      ImageId: ami-04505e74c0741db8d
      InstanceType: t2.micro
      KeyName: KeyName
      SecurityGroupIds: 
        - WobblelandSecurityGroup
      UserData: 
        Fn::Sub: |
            #!/bin/bash
            wget -qO - https://www.mongodb.org/static/pgp/server-4.4.asc | sudo apt-key add -
            echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 multiverse" | sudo tee /etc/apt/sources.list.d/mongodb-org-4.4.list
            sudo apt-get update
            sudo apt-get install -y mongodb-org
            
    Type: "AWS::EC2::Instance"
  WobblelandSecurityGroup: 
    Properties: 
      GroupDescription: "Allow HTTP/HTTPS and SSH inbound and outbound traffic"
      GroupName: 
        - "-"
        - 
          - Wobbleland-security-group
          - dev
      SecurityGroupIngress: 
        - 
          CidrIp: 0.0.0.0/0
          FromPort: 80
          IpProtocol: tcp
          ToPort: 80
        - 
          CidrIp: 0.0.0.0/0
          FromPort: 443
          IpProtocol: tcp
          ToPort: 443
        - 
          CidrIp: 0.0.0.0/0
          FromPort: 22
          IpProtocol: tcp
          ToPort: 22
    Type: "AWS::EC2::SecurityGroup"
  DefaultPrivateRoute: 
    Properties: 
      DestinationCidrBlock: 0.0.0.0/0
      NatGatewayId: NatGateway
      RouteTableId: PrivateRouteTable
    Type: "AWS::EC2::Route"
  DefaultPublicRoute: 
    DependsOn: InternetGatewayAttachment
    Properties: 
      DestinationCidrBlock: 0.0.0.0/0
      GatewayId: InternetGateway
      RouteTableId: PublicRouteTable
    Type: "AWS::EC2::Route"
  InternetGateway: 
    Properties: 
      Tags: 
        - 
          Key: Name
          Value: EnvironmentName
        - 
          Key: Env
          Value: EnvironmentName
    Type: "AWS::EC2::InternetGateway"
  InternetGatewayAttachment: 
    Properties: 
      InternetGatewayId: InternetGateway
      VpcId: VPC
    Type: "AWS::EC2::VPCGatewayAttachment"
  NatGateway: 
    Properties: 
      AllocationId: NatGatewayEIP.AllocationId
      SubnetId: PublicSubnet
    Type: "AWS::EC2::NatGateway"
  NatGatewayEIP: 
    DependsOn: InternetGatewayAttachment
    Properties: 
      Domain: vpc
    Type: "AWS::EC2::EIP"
  PrivateRouteTable: 
    Properties: 
      Tags: 
        - 
          Key: Name
          Value: "${EnvironmentName} Private Routes (AZ1)"
        - 
          Key: Env
          Value: EnvironmentName
      VpcId: VPC
    Type: "AWS::EC2::RouteTable"
  PrivateSubnet: 
    Properties: 
      AvailabilityZone: 
        - 0
      CidrBlock: PrivateSubnetCIDR
      MapPublicIpOnLaunch: false
      Tags: 
        - 
          Key: Name
          Value: "${EnvironmentName} Private Subnet (AZ1)"
        - 
          Key: Env
          Value: EnvironmentName
      VpcId: VPC
    Type: "AWS::EC2::Subnet"
  PublicRouteTable: 
    Properties: 
      Tags: 
        - 
          Key: Name
          Value: "${EnvironmentName} Public Routes"
        - 
          Key: Env
          Value: EnvironmentName
      VpcId: VPC
    Type: "AWS::EC2::RouteTable"
  PublicSubnet: 
    Properties: 
      AvailabilityZone: 
        - 0
      CidrBlock: PublicSubnetCIDR
      MapPublicIpOnLaunch: true
      Tags: 
        - 
          Key: Name
          Value: "${EnvironmentName} Public Subnet (AZ1)"
        - 
          Key: Env
          Value: EnvironmentName
      VpcId: VPC
    Type: "AWS::EC2::Subnet"
  VPC: 
    Properties: 
      CidrBlock: VpcCIDR
      EnableDnsHostnames: true
      EnableDnsSupport: true
      Tags: 
        - 
          Key: Name
          Value: EnvironmentName
        - 
          Key: Env
          Value: EnvironmentName
    Type: "AWS::EC2::VPC"

CodePudding user response：

Instead of:

GatewayId: InternetGateway

you should have

InternetGatewayId: !GetAtt InternetGateway.InternetGatewayId