building a python text-based game: im trying to access a specific value inside of a dictionary-CodePudding

hey everybody i am building a text based game for a class where i am moving between rooms and trying collect all the items without going into the room with the villian, in this case the Record Executive, and im just having issues accessing the item directly so that I can add it my inventory list..

here is my dictionary:

rooms = {
    'Lobby':{'East': 'Bar'},
    'Roof':{'South': 'Bar', 'East': 'Stage', 'Item': 'Steel guitar'},
    'Bar':{'West': 'Lobby', 'North': 'Roof', 'East': 'Bathroom', 'South': 'Basement', 'Item': 'Keyboard'},
    'Basement':{'North': 'Bar', 'East': 'Studio', 'Item': 'Drums'},
    'Stage':{'West': 'Roof', 'Item': 'Microphone'},
    'Soundcheck':{'South': 'Bathroom', 'Item': 'Bass Guitar'},
    'Bathroom':{'North': 'Soundcheck', 'West': 'Bar', 'Item': 'Electric Guitar'},
    'Studio': {'West': 'Basement', 'Item': 'Record Executive'}
}

heres my movement code:

while gameOver != True:
    playerStats(currentRoom, inventory, rooms)
    # currentRoom
    playerMove = input('Enter your move:\n')

    try:
        currentRoom = rooms[currentRoom][playerMove]
    except Exception:
        print('Invalid move')
        continue

I move East from Lobby and my current room changes to Bar like it should but I don't know how to get to the 'Item' property in it so I can add 'Keyboard' to my inventory list... any help would be much appreciated!! thank you

CodePudding user response：

To index the dictionary you want

currentRoom['Item']

You will add it to the list after doing the move, so at the end (after the "try", "except", part) you will add:

    inventory.append(currentRoom['Item'])

By putting it after the movement code, you take the item from the new room, not the existing room.

Some rooms might not have an item, so then you can do:

    try:
        inventory.append(currentRoom['Item'])
    except KeyError:
        pass

This prevents an error when you move into the room with no item.

Also you might want to remove the item from the room when you take it. So you can do.

    try:
        inventory.append(currentRoom['Item'])
        del currentRoom['Item']
    except KeyError:
        pass

The del removes the key from the dictionary

By the way, in your movement code, you should also change

    except Exception:

    except KeyError:

So if there is a different exception (e.g. you press ctrl-C) then it does not catch it.

CodePudding user response：

just like this command

currentRoom = rooms[currentRoom][playerMove]

you can try to append the item in the room to the variable (inventory), preferrable a list (or a set if that fulfills your requirement)

inventory = []

for i in rooms:
    for j in i:
        if j == 'Item':
            inventory.append(rooms[i][j])

now it shall look like this:

inventory = []
gameOver = False

rooms = {
    'Lobby':{'East': 'Bar'},
    'Roof':{'South': 'Bar', 'East': 'Stage', 'Item': 'Steel guitar'},
    'Bar':{'West': 'Lobby', 'North': 'Roof', 'East': 'Bathroom', 'South': 'Basement', 'Item': 'Keyboard'},
    'Basement':{'North': 'Bar', 'East': 'Studio', 'Item': 'Drums'},
    'Stage':{'West': 'Roof', 'Item': 'Microphone'},
    'Soundcheck':{'South': 'Bathroom', 'Item': 'Bass Guitar'},
    'Bathroom':{'North': 'Soundcheck', 'West': 'Bar', 'Item': 'Electric Guitar'},
    'Studio': {'West': 'Basement', 'Item': 'Record Executive'}
}


while not gameOver:
    playerStats(currentRoom, inventory, rooms)
    # currentRoom
    playerMove = input('\n Enter your move: ')

    if playerMove == 'pick' or playerMove == 'acquire' or playerMove == 'get':
        # add to inventory if exists
        for i in rooms:
            for j in i:
                if j == 'Item':
                    inventory.append(rooms[i][j])
                else:
                    print('nothing to pick')
    else:
        try:
            currentRoom = rooms[currentRoom][playerMove]
        except Exception:
            print('Invalid move')
            continue

EDIT:

Also you shall now delete the item from the room, since it is now acquired--

(As also pointed out by @Addlestrop in their answer)

        for i in rooms:
            for j in i:
                if j == 'Item':
                    inventory.append(rooms[i][j])
                    del rooms[i][j]
                    # copy item to inventory and delete from the room
                else:
                    print('nothing to pick')