I can't seem to get my delete, edit and add review functionality working. The errors come as soon as I try to navigate to the urls I have set up. When I try and add a new review using my link on the reviews page I get the below message:

TemplateDoesNotExist at /reviews/add

I don't understand why because I have linked the url above to the template, which I have created.

The issue I have with my edit/delete views is that the url it searches for when I click the button is just /edit/ or /delete/ rather than reviews/edit/int:pk or reviews/delete/int:pk as per my urls.

I have pasted my code below, any help would be much appreciated! I have the feeling I am going to kick myself when I realise!

reviews.html:

{% extends "base.html" %}
{% load static %}

{% block content %}
<div >
    <div >
        <div >
            <h2><strong>Reviews</strong></h2>
        </div>
    </div>
    {% for review in reviews %}
    <hr >
    <div >
        <div >
            <h2 >{{ review.title }}</h2>
            <p >{{ review.content }}</p>
            <div >
                <p>By: {{ review.user }}</p>
                <p>Created on: {{ review.created }}</p>
                <p>Last Updated: {{ review.updated }}</p>
            </div>
            <!-- Add user authentication if -->
            <div >
                <a href="edit/{{ review.id }}" >
                    <button >Edit</button></a>
                <a href="delete/{{ review.id }}" >
                    <button >Delete</button></a>
            </div>
        </div>
    </div>
    {% endfor %}
    
    <div >
        <div >
            {% if user.is_authenticated %}
            <a href="{% url 'home:add_review' %}">
                <button >Add a review</button>
            </a>
            {% else %}
            <p>If you would like to add your own review, please login or sign up if you haven't already!</p>
            {% endif %}
        </div>
    </div>
    
</div>
{% endblock %}

add_review.html:

{% extends "base.html" %}
{% load static %}

{% block content %}
<div >
    <div >
        <div >
            <form method="post" style="margin-top: 1.3em;">
                {{ review_form }}
                {% csrf_token %}
                <button type="submit" >Submit</button>
            </form>
        </div>
    </div>
{% endblock %}

views.py:

from django.shortcuts import render
from django.views import View
from django.urls import reverse_lazy
from django.views.generic import UpdateView, DeleteView
from .models import Reviews
from .forms import ReviewForm


def home(request):
    ''' Returns the home page.'''
    return render(request, 'home/index.html')


def reviews(request):
    ''' Returns the reviews page.'''

    serialized_reviews = []

    reviews = Reviews.objects.all()

    for review in reviews:
        serialized_reviews.append({
            "title": review.title,
            "content": review.content,
            "user": review.user,
            "created": review.created,
            "updated": review.updated,
        })

    context = {
        "reviews": serialized_reviews
        }
    print(serialized_reviews)
    return render(request, 'home/reviews.html', context)


class AddReview(View):
    '''View which allows the user to add a new review.'''

    def get(self, request, *args, **kwargs):

        review = Reviews
        review_form = ReviewForm
             
        context = {
            'review': review,
            'review_form': review_form,
            'user': review.user,
            'title': review.title,
            'content': review.content,
        }
        return render(request, 'add_review.html', context)
    
    def post(self, request, *args, **kwargs):

        review_form = ReviewForm(data=request.POST)

        if review_form.is_valid():
            obj = review_form.save(commit=False)
            obj.user = request.user
            obj.save()
            
        return redirect("home:reviews")


class DeleteReview(DeleteView):
    '''View which allows the user to delete the selected review.'''
    model = Reviews
    template_name = 'delete_review.html'
    success_url = reverse_lazy('reviews')


class EditReview(UpdateView):
    '''View which allows the user to edit the selected review.'''
    model = Reviews
    template_name = 'edit_review.html'
    fields = ['title', 'content']

urls.py:

from django.urls import path
from . import views


app_name = 'home'

urlpatterns = [
    path('', views.home, name='home'),
    path('reviews', views.reviews, name='reviews'),
    path('reviews/add', views.AddReview.as_view(), name='add_review'),
    path('reviews/delete/<int:pk>', views.DeleteReview.as_view(), name='delete_review'),
    path('reviews/edit/<int:pk>', views.EditReview.as_view(), name='edit_review'),
]

CodePudding user response：

I think you're writing in your urls the wrong way, like this below your div text-center:

<a href="edit/{{ review.id }}" >

It should be:

<a href="{% url 'yourappname:edit' review.id %}">

CodePudding user response：

The main difference is my app name, which is 'core'. Also, I forgot to add the content field to the model, but that is easily done, the form will just handle it as soon as you do the migration. (except on list.html)

models.py

from django.db import models
from django.contrib.auth import get_user_model
from django.utils import timezone

class Reviews(models.Model):
    user = models.ForeignKey(get_user_model(), on_delete=models.CASCADE)
    title = models.CharField(max_length=128)
    created_at = models.DateTimeField(auto_now_add=timezone.now())
    updated_at = models.DateTimeField(auto_now=timezone.now())

forms.py

from django import forms
from core.models import Reviews

class ReviewsForm(forms.ModelForm):
    
    class Meta:
        model = Reviews
        fields = '__all__'

views.py

from core.models import Reviews
from core.forms import ReviewsForm
from django.shortcuts import render, redirect

def list_reviews(request):
    reviews = Reviews.objects.all()

    context = {
        "reviews": reviews
        }
    return render(request, 'reviews/list.html', context)

def add_review(request):    
    if request.method == 'POST':
        form = ReviewsForm(request.POST)

        if form.is_valid():
            form.save()
            return redirect('/reviews/')
    else:
        form = ReviewsForm()

    context = {
        'form': form
        }
    return render(request, 'reviews/detail.html', context)

def edit_review(request, pk):    
    if request.method == 'POST':
        form = ReviewsForm(request.POST)

        if form.is_valid():
            obj = Reviews.objects.get(id=pk)
            obj.title = form.cleaned_data['title']
            obj.user = form.cleaned_data['user']
            obj.save()
            return redirect('/reviews/')
    else:
        obj = Reviews.objects.get(id=pk)
        form = ReviewsForm(instance=obj)

    context = {
        'form': form
        }
    return render(request, 'reviews/detail.html', context)

def delete_review(request, pk):
    obj = Reviews.objects.get(id=pk)
    obj.delete()
    return redirect('/reviews/')

urls.py

from django.urls import path
import core.views as views

app_name = 'core'

urlpatterns = [
    path('reviews/', views.list_reviews, name='list-reviews'),
    path('reviews/add', views.add_review, name='add-review'),
    path('reviews/edit/<int:pk>/', views.edit_review, name='edit-review'),
    path('reviews/delete/<int:pk>/', views.delete_review, name='delete-review'),
]

list.html

{% extends "base.html" %}
{% load static %}

{% block content %}
<div >
    <div >
        <div >
            <h2><strong>Reviews</strong></h2>
        </div>
    </div>
    {% for review in reviews %}
    <hr >
    <div >
        <div >
            <h2 >{{ review.title }}</h2>
            <p >{{ review.content }}</p>
            <div >
                <p>By: {{ review.user }}</p>
                <p>Created on: {{ review.created_at }}</p>
                <p>Last Updated: {{ review.updated_at }}</p>
            </div>
            <!-- Add user authentication if -->
            <div >
                <a href="{% url 'core:edit-review' pk=review.id %}" >
                    <button >Edit</button></a>
                <a href="{% url 'core:delete-review' pk=review.id %}"  >
                    <button >Delete</button></a>
            </div>
        </div>
    </div>
    {% endfor %}
    
    <div >
        <div >
            {% if user.is_authenticated %}
            <a href="{% url 'core:add-review' %}">
                <button >Add a review</button>
            </a>
            {% else %}
            <p>If you would like to add your own review, please login or sign up if you haven't already!</p>
            {% endif %}
        </div>
    </div>
    
</div>
{% endblock %}

detail.html

{% extends "base.html" %}
{% load static %}

{% block content %}
<div >
    <div >
        <div >
            <form method="post" style="margin-top: 1.3em;"> 
                {% csrf_token %}
                <table>                    
                    {{ form }}
                </table>
                <button type="submit" >Save</button>
            </form>
        </div>
    </div>
{% endblock %}