Parse Json exception while posting data to api-CodePudding

Hello all I am trying to save some post data from related tables. Cities and halls. Here is my City model

package com.example.model;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.Table;

@Entity
@Table(name = "cities")

public class Cities {

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name = "id")
private int id;

@Column(name = "name")
private String name;

public int getId() {
    return id;
}

public void setId(int id) {
    this.id = id;
}

public String getName() {
    return name;
}

public void setName(String name) {
    this.name = name;
}



}

Here is my Halls model:

package com.example.model;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.EntityListeners;
import javax.persistence.FetchType;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.JoinColumn;
import javax.persistence.ManyToOne;
import javax.persistence.Table;
import java.util.Date;
import org.hibernate.annotations.OnDelete;
import org.hibernate.annotations.OnDeleteAction;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;

@Entity
@Table(name = "halls")

public class Halls {
    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @Column(name = "id")
    private int id;

     @Column(name = "name")
     private String name;

     @Column(name = "placeqty")
     private int placeqty;
      
     @JsonIgnoreProperties({"hibernateLazyInitializer", "handler","ignoreUnknown = true"})
    
     @ManyToOne(fetch = FetchType.LAZY, optional = false)
        @JoinColumn(name = "cityid", nullable = false)
        @OnDelete(action = OnDeleteAction.CASCADE)
        private Cities cityid;

    public int getId() {
        return id;
    }

    public void setId(int id) {
        this.id = id;
    }

    public String getName() {
        return name;
    }

    public void setName(String name) {
        this.name = name;
    }

    public int getPlaceqty() {
        return placeqty;
    }

    public void setPlaceqty(int placeqty) {
        this.placeqty = placeqty;
    }

    public Cities getCityid() {
        return cityid;
    }

    public void setCityid(Cities cityid) {
        this.cityid = cityid;
    }
     
     
}

It is related on column cityid to cities model. Here is my controller method to create a new hall in Spring boot:

@RequestMapping(value="/add", method=RequestMethod.POST)
        public ResponseEntity add(@RequestBody Halls hall)
        {
         hallsService.addHall(hall);
          return new ResponseEntity<>(hall, HttpStatus.CREATED);

        }

And my Angular form:

<p>Добавить зал</p>
<div>
  <div class="submit-form">
    <div *ngIf="!submitted">
      <div class="form-group">
        <label for="title">Название</label>
        <input
          type="text"
          class="form-control"
          id="title"
          required
          [(ngModel)]="hall.name"
          name="name"
        />
      </div>


      <div class="form-group">
        <label for="placeqty">кол-во мест</label>
        <input
          type="text"
          class="form-control"
          id="placeqty"
          required
          [(ngModel)]="hall.placeqty"
          name="placeqty"
        />
      </div>

      <select  [(ngModel)]="hall.cityid" name="cityid">
        <option *ngFor="let c of cities" value="{{c.id}}">{{c.name}}</option>
      </select>`


      <button (click)="saveHall()" class="btn btn-success">Сохранить</button>
    </div>

    <div *ngIf="submitted">
      <h4>Зал добавлен!</h4>
      <button class="btn btn-success" (click)="newHall()">Добавить еще</button>
    </div>
  </div>
</div>

And my component looks like this:

import { Component, OnInit } from '@angular/core';
import { Hall } from 'src/app/models/hall.model';
import { City } from 'src/app/models/city.model';

import { HallService } from 'src/app/services/hall.service';
import { CityService } from 'src/app/services/city.service';


@Component({
  selector: 'app-add-hall',
  templateUrl: './add-hall.component.html',
  styleUrls: ['./add-hall.component.css']
})
export class AddHallComponent implements OnInit {
  cities?: City[];

  // @ts-ignore
  hall: Hall = {
    name: '',
    placeqty:'',
    cityid:this.retrieveCities(),




  };
  submitted = false;

  constructor(private  hallService:HallService,private cityService:CityService) { }

  ngOnInit(): void {
  }
  saveHall(): void {
    const data = {
      name: this.hall.name,
      placeqty: this.hall.placeqty,
      cityid: this.hall.cityid

    };
    console.log(data.cityid);
    this.hallService.create(data)
      .subscribe(
        response => {
        console.log("city")
          console.log(response);
          this.submitted = true;
        },
        error => {
          console.log(error);
        });
  }
  newHall(): void {
    this.submitted = false;
    this.hall = {
      name: '',
      placeqty: '',
      cityid: this.retrieveCities()


    };
  }

  retrieveCities(): any {
   this.cityService.getAll()
      .subscribe(
        data => {
          this.cities = data;
          console.log(data);
          return data;
          },
        error => {
          console.log(error);
      return error;
        });

  }
}

And my Halls model:

import {City} from "./city.model";

export class Hall {
  id?:any;
  name?:string;
  placeqty?:string;

  cityid?:City;

}

So, after posting this form I get the following error:

 2021-11-01 11:34:10.236  WARN 14120 --- [io-8888-exec-10] .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Cannot construct instance of `com.example.model.Cities` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('2'); nested exception is com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of `com.example.model.Cities` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('2')
     at [Source: (PushbackInputStream); line: 1, column: 43] (through reference chain: com.example.model.Halls["cityid"])]

What am I doing incorrectly in this case?

Will add my city model from Java and Angular

Java:

package com.example.model;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.Table;

@Entity
@Table(name = "cities")

public class Cities {

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name = "id")
private int id;

@Column(name = "name")
private String name;

public int getId() {
    return id;
}

public void setId(int id) {
    this.id = id;
}

public String getName() {
    return name;
}

public void setName(String name) {
    this.name = name;
}


    

}

And the angular part of it:

export class City {
  id?:any;
  name?:string;
}

Where exectly I have to convert it? Here is my post payload:

name: "test", placeqty: "100", cityid: "2"}
cityid: "2"
name: "test"
placeqty: "

Also I tryed to use ngvalue instead of a value:

 <select  [(ngModel)]="hall.cityid" name="cityid">
        <option *ngFor="let c of cities" [ngValue]='c.id'>{{c.name}}</option>
      </select>

With no luck.

CodePudding user response：

com.example.model.Halls["cityid"])]

"no String-argument constructor/factory method to deserialize from String value ('2')"

the problem is in your JSON you are probably sending the ID as a string. make sure the field is a number.

CodePudding user response：

Finaly I got it fixed. I edited the selectbox with cities this way:

<select  [(ngModel)]="hall.cityid" name="cityid">
        <option *ngFor="let city of cities" [ngValue]="city">{{city.name}}</option>

      </select>

And it fixed the problem.

CodePudding user response：

You need to add an all argumenet contractor. Or you can use @AllArgsConstructor or @Data from Lombok.