Best way for Selenium to wait for elements that are not always present-CodePudding

I'm writing a simple python/selenium code to extract data from a url. I would like to know what is the best way to wait for a group of elements to be visible, like this:

Element A: A dialog that randomly appears on the website. If the element is there, it must be closed/clicked. If not, ignored.
Element B: Article price. If the article is not free, the element is  present on the website.
Element C: Article price. If the is free, the element is present on the website
Element D: Shipping time (sometimes it is inside an iframe)
Element E: Shipping time (other time is is outside the iframe)

Sometimes, the elements take a while to load, so I've added a time.sleep(1.5). I know that selenium have a expected_conditions wait, but that works for a element that is always present.

This is the code I have so far, but I don't think it is good enought as it used an implicit wait. How can I improve this code?

try:
    time.sleep(1.5)
    try:
        #ElementA
        driver.find_element(By.CSS_SELECTOR, "div.andes-dialog__wrapper div.andes-dialog__container a.andes-dialog_-close").click()  
    except: pass
    try:
        #Element B: Article price in iframe (not free)
        shipping_price=driver.find_element(By.CSS_SELECTOR, "div.ui-shipping_column.ui-shipping_price span.price_amount").text
    except:
        #Element C: Article price in iframe (free)
        shipping_price=driver.find_element(By.CSS_SELECTOR, "div.ui-shipping__column.ui-shipping_price").text
    #Element D: Shipping time in iframe
    shipping_time=driver.find_element(By.CSS_SELECTOR, "div.ui-shipping_column.ui-shipping_description span.ui-shipping__title").text
except Exception as e:
    #Element E: Shipping time outside iframe
    shipping_time=driver.find_element(By.CSS_SELECTOR, "form.ui-pdp-buybox div.ui-pdp-shipping p.ui-pdp-media__title").text

CodePudding user response：

from selenium import webdriver
driver = webdriver.Firefox()
driver.implicitly_wait(6)

CodePudding user response：

You should you WebDriverWait like this:

from selenium import webdriver
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC

driver = webdriver.Chrome("D:/chromedriver/94/chromedriver.exe")

driver.get("https://www.website.com")
# wait 60 seconds 
wait = WebDriverWait(driver,60)
try:
    wait.until(EC.presence_of_element_located((By.CSS_SELECTOR, "div.ui-shipping_column.ui-shipping_price span.price_amount")))
    shipping_price=driver.find_element(By.CSS_SELECTOR, "div.ui-shipping_column.ui-shipping_price span.price_amount").text
except Exception as ex:
    # do something
    print(ex)