The task is:
Given an array of digitals numbers, return a new array of length number containing the last even numbers from the original array (in the same order).
Codewars compiler shows the "Execution Timed Out (12000 ms)" error, though the code is working as intended. Please help to optimize my code, because I can't figure it out myself
My code:
function evenNumbers(array, number) {
for (let i=0; i < array.length; i ) {
if (array[i] % 2 != 0) {
array.splice(i, 1);
i -= 1;
}
}
array.splice(0, array.length - number)
return array;
}
CodePudding user response：
You're iterating over the whole array, but you only need to iterate over number elements. For example, given a number of 5, you only need to iterate until you find 5 values fulfilling the condition - you don't want to iterate over all of a 10,000-length array if you don't have to. (Codewars tests often have such huge object structures.)
It also says to return a new array, not modify the existing array.
const evenNumbers = (array, number) => {
const newArr = [];
for (let i = array.length - 1; i >= 0 && newArr.length <= number; i--) {
if (array[i] % 2 === 0) newArr.unshift(array[i]);
}
return newArr;
};
console.log(evenNumbers(
[1, 2, 3, 4, 5, 6, 7, 8],
3
));