Home > OS >  Two recycler view on same fragment, holder or db brings wrong data when I select item
Two recycler view on same fragment, holder or db brings wrong data when I select item

Time:02-11

Like title I can't get correct item data, now imagine I have 2 recycler view list on my main fragment, one recycler view is vertical, other horizontal. If I use only one recycler everything is working fine. But when I add other one it's opening items randomly, but that random data openings only random both recyclers positions. Like my first recycler have [a,b,c,d] , other recycler have [e,f,g,h]. When I click first item of first recycler its go to other fragment which shows detail, its opening e instead of a, if I go back and retry it, its opening e again, retry and its a !! so its opening randomly, why this is happening why can't I open correct data? I put Log.d on my adapters and when I click recycler items, adapters log says u clicked "a" but my detail fragment shows me data of "e". What I am doing wrong? Here is my codes:(I have lots of codes so I share what we need)

my databases TvDAO:

import androidx.room.Dao
import androidx.room.Insert
import androidx.room.Query
import com.bt.filmdenemesi.model.Result

@Dao
interface TVDAO {
//Veri erişim nesnesi
@Insert
suspend fun insertAll(vararg movie: Result) : List<Long>

@Query("SELECT * FROM Result")
suspend fun getAllTV() : List<Result>

@Query("SELECT * FROM Result WHERE uuid2=:diziId")
suspend fun getTV(diziId:Int) : Result

@Query("DELETE FROM Result")
suspend fun deleteAllTV(

)
}

Tv Database:

@Database(entities = arrayOf(Result::class), version = 1)
abstract class TvDatabase: RoomDatabase() {
abstract fun tvDao(): TVDAO

companion object{
    @Volatile
    private var INSTANCE: TvDatabase?=null
     fun databaseOlustur2(context: Context): TvDatabase {
        return INSTANCE ?: synchronized(this){
            val instance = Room.databaseBuilder(context.applicationContext,TvDatabase::class.java, "tvdatabase").fallbackToDestructiveMigration().build()
            INSTANCE=instance
            instance
         }
     }
 }

 }

movie Dao:

 @Dao
 interface MovieDAO {
//Veri erişim nesnesi
@Insert
suspend fun insertAll(vararg movie: Movie) : List<Long>

@Query("SELECT * FROM Movie")
suspend fun getAllMovie() : List<Movie>

@Query("Select * from Movie where uuid=:movieId")
suspend fun getMovie(movieId:Int) : Movie

@Query("Delete from Movie")
suspend fun deleteAllMovie(

)
}

movie database:

@Database(entities = arrayOf(Movie::class ), version = 1)
abstract class MovieDatabase:RoomDatabase() {
abstract fun movieDao(): MovieDAO

//singleton

companion object{

     @Volatile  private var instance: MovieDatabase? = null

    private val lock = Any()
    operator fun invoke(context: Context) = instance ?: synchronized(lock){
        instance?: databaseOlustur(context).also {
            instance = it
        }
    }


    private fun databaseOlustur(context: Context)= Room.databaseBuilder(
        context.applicationContext,
        MovieDatabase::class.java,"moviedatabase").build()
}


}

my adapters:

 class vizyonrecycleradapter(val diziListesi: ArrayList<Result>):RecyclerView.Adapter<vizyonrecycleradapter.DiziViewHolder>() {
class DiziViewHolder(itemview: View) : RecyclerView.ViewHolder(itemview)

override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): DiziViewHolder {
    val inflater = LayoutInflater.from(parent.context)
    val view = inflater.inflate(R.layout.now_playing_recycler_row, parent, false)
    return DiziViewHolder(view)
}

override fun onBindViewHolder(holder: DiziViewHolder, konum: Int) {
    holder.itemView.tv_ismi.text=diziListesi.get(konum).name
    val fotoDenemeleri = "https://image.tmdb.org/t/p/w500"
    val fotobirlestirme: String = "${fotoDenemeleri}"  diziListesi.get(konum).posterPath
    holder.itemView.vizyon.gorselIndir(fotobirlestirme, placeHolderYap(holder.itemView.context))
    holder.itemView.setOnClickListener {
        val action2 = AnaSayfaDirections.actionAnaSayfaToDetaySayfasi(diziListesi[konum].uuid2)
        Log.d("movie-title","${diziListesi.get(konum).originalName}")
        Navigation.findNavController(it).navigate(action2)
    }
}
override fun getItemCount(): Int {
    return diziListesi.size
}
fun diziListesiniGuncelle(yeniDiziListesi: List<Result>) {
    diziListesi.clear()
    diziListesi.addAll(yeniDiziListesi)
    notifyDataSetChanged()
}
}

other adapter:

   class MovieRecyclerAdapter(val movieListesi: ArrayList<Movie>):RecyclerView.Adapter<MovieRecyclerAdapter.MovieViewHolder>() {
class MovieViewHolder(itemview: View) :RecyclerView.ViewHolder(itemview)

override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): MovieViewHolder {
    val inflater = LayoutInflater.from(parent.context)
    val view = inflater.inflate(R.layout.movie_recycler_row,parent,false)
    return MovieViewHolder(view)
}

override fun onBindViewHolder(holder: MovieViewHolder, position: Int) {
    holder.itemView.movieId.text= movieListesi.get(position).title

    val fotoDenemeleri = "https://image.tmdb.org/t/p/w500"
    val fotobirlestirme: String = "${fotoDenemeleri}" movieListesi.get(position).backdropPath
    holder.itemView.ana_foto.gorselIndir(fotobirlestirme, placeHolderYap(holder.itemView.context))
    holder.itemView.setOnClickListener {
        val action = AnaSayfaDirections.actionAnaSayfaToDetaySayfasi(movieListesi.get(position).uuid)
        Log.d("movie-title","${movieListesi.get(position).title}")
        Navigation.findNavController(it).navigate(action)
    }
}
override fun getItemCount(): Int {
    return movieListesi.size
}
fun movieListesiniGuncelle(yeniMovieListesi: List<Movie>){
    movieListesi.clear()
    movieListesi.addAll(yeniMovieListesi)
    notifyDataSetChanged()
}
}

my base ViewModel:

open class BaseViewModel(application: Application) : AndroidViewModel(application),CoroutineScope {

private val job = Job()
override val coroutineContext: CoroutineContext
    get() = job   Dispatchers.Main

override fun onCleared() {
    super.onCleared()
    job.cancel()
}

}

detail ViewModel:

class MovieDetayiViewModel(application: Application): BaseViewModel(application) {

val diziLiveData = MutableLiveData<Result>()
val movieLiveData = MutableLiveData<Movie>()
val aramaLiveData = MutableLiveData<ResultX>()

fun roomVerisiniAl2(uuid2: Int){
    launch {
        val dao2=TvDatabase.databaseOlustur2(getApplication()).tvDao().getTV(uuid2)
        //val dizi = dao.getTV(uuid2)
        diziLiveData.value=dao2

    }
}

fun roomVerisiniAl(uuid: Int){
    launch {
        val dao= MovieDatabase(getApplication()).movieDao().getMovie(uuid)
   //     val film = dao.getMovie(uuid)

        movieLiveData.value=dao

    }
}
fun roomVerisiniAl3(uuid3: Int){
    launch {
        val dao= AramaDatabase(getApplication()).aramaDao()
        val arama = dao.getMovie(uuid3)
        aramaLiveData.value=arama
    }
}
}

movielistviewmvdel:

class MovieListesiViewModel(application: Application): BaseViewModel(application){
val filmler = MutableLiveData<List<Movie>>()
val dizi = MutableLiveData<List<Result>>()
val arama = MutableLiveData<List<ResultX>>()
val filmHataMesaji = MutableLiveData<Boolean>()
val filmYukleniyor = MutableLiveData<Boolean>()
private var guncellemeZamani = 1 * 60 * 1000 * 1000 * 1000L
private val filmApiServis = FilmAPIServis()
private val disposable = CompositeDisposable()
private val disposable2 = CompositeDisposable()
private val disposable3 = CompositeDisposable()//kullan at
private val ozelSharedPrefences = OzelSharedPrefences(getApplication())

fun refreshData(){
    val kaydedilmeZamani = ozelSharedPrefences.zamaniAl()
    if(kaydedilmeZamani != null && kaydedilmeZamani !=0L && System.nanoTime()-kaydedilmeZamani < guncellemeZamani){
        verileriSQLitedenAl()
    }else{
        verileriInternettenAl()
    }
}
fun refreshFromInternet(){

    verileriInternettenAl()
}
    private fun verileriSQLitedenAl(){
    filmYukleniyor.value = true
    launch {
       val movieListesi = MovieDatabase(getApplication()).movieDao().getAllMovie()
       movieleriGoster(movieListesi)
       val diziListesi = TvDatabase.databaseOlustur2(getApplication()).tvDao().getAllTV()
       tvleriGoster(diziListesi)
    }
  launch {
      val aramaListesi = AramaDatabase(getApplication()).aramaDao().getAllMovie()
      aramalariGoster(aramaListesi)
   }


}

private fun verileriInternettenAl(){
    filmYukleniyor.value = true
    disposable.add(
       filmApiServis.getData()
            .subscribeOn(Schedulers.newThread())
            .observeOn(AndroidSchedulers.mainThread())
            .subscribeWith(object: DisposableSingleObserver<GetMoviesResponse>(){
                override fun onSuccess(t: GetMoviesResponse) {
                    filmler.value= t.results
                    filmHataMesaji.value=false
                    filmYukleniyor.value=false
                    sqliteSakla(t.results)
            //        Toast.makeText(getApplication(),"Filmler internetten yüklendi",Toast.LENGTH_LONG).show()
                }
                override fun one rror(e: Throwable) {
                    filmHataMesaji.value=true
                    filmYukleniyor.value=false
                    e.printStackTrace()
                }
            })
    )
    disposable2.add(
        filmApiServis.getVizyondakiler()
        .subscribeOn(Schedulers.newThread())
        .observeOn(AndroidSchedulers.mainThread())
        .subscribeWith(object: DisposableSingleObserver<NowPlaying>(){
            override fun onSuccess(t: NowPlaying) {
                dizi.value= t.results
                filmHataMesaji.value=false
                filmYukleniyor.value=false
                diziSqLiteSakla(t.results)
            }
            override fun one rror(e: Throwable) {
                filmHataMesaji.value=true
                filmYukleniyor.value=false
                e.printStackTrace()
            }
        })
    )
}
 fun aramayiInternettenAl(denemeText:String){
    disposable3.add(
        filmApiServis.getArama(denemeText)
            .subscribeOn(Schedulers.newThread())
            .observeOn(AndroidSchedulers.mainThread())
            .subscribeWith(object: DisposableSingleObserver<search>(){
                override fun onSuccess(t: search) {
                    arama.value= t.results
                    aramaSqliteSakla(t.results)
                }
                override fun one rror(e: Throwable) {
                    e.printStackTrace()
                }
            })
    )
}

 private fun movieleriGoster(filmlerListesi : List<Movie>?){
    filmler.value= filmlerListesi
    filmHataMesaji.value=false
    filmYukleniyor.value=false
}
private fun tvleriGoster(tvListesi: List<Result>?){
    dizi.value= tvListesi
    filmHataMesaji.value=false
    filmYukleniyor.value=false
}
private fun aramalariGoster(aramaListesi: List<ResultX>){
    arama.value= aramaListesi
}

private fun sqliteSakla(filmListesi : List<Movie>){
    launch {

        val dao = MovieDatabase(getApplication()).movieDao()//dao içerisindeki fonksiyonlara ulaşmak için
        dao.deleteAllMovie()
        val uuidListesi = dao.insertAll(*filmListesi.toTypedArray())//tek tek movie haline getirmek için typed array. (*) koymak lazım
        var i = 0
        while (i < filmListesi.size){
            filmListesi[i].uuid = uuidListesi[i].toInt()//uuid ye ulaştık modemdeki idleri eşledik
            i = i   1
        }
        movieleriGoster(filmListesi)
    }
    ozelSharedPrefences.zamaniKaydet(System.nanoTime())
}
private fun diziSqLiteSakla(diziListesi : List<Result>){
    launch {

        val dao2 = TvDatabase.databaseOlustur2(getApplication()).tvDao()//dao içerisindeki fonksiyonlara ulaşmak için
        dao2.deleteAllTV()
        val uuidListesi2 = dao2.insertAll(*diziListesi.toTypedArray())//tek tek movie haline getirmek için typed array. (*) koymak lazım
        var i = 0
        while (i < diziListesi.size){
            diziListesi[i].uuid2 = uuidListesi2[i].toInt()//uuid ye ulaştık modemdeki idleri eşledik
            i = i   1
        }
        tvleriGoster(diziListesi)
    }
    ozelSharedPrefences.zamaniKaydet(System.nanoTime())
}
private fun aramaSqliteSakla(aramaListesi : List<ResultX>){
    launch {

        val dao = AramaDatabase(getApplication()).aramaDao()//dao içerisindeki fonksiyonlara ulaşmak için
        dao.deleteAllMovie()
        val uuidListesi3 = dao.insertAll(*aramaListesi.toTypedArray())//tek tek movie haline getirmek için typed array. (*) koymak lazım
        var i = 0
        while (i < aramaListesi.size){
            aramaListesi[i].uuid3 = uuidListesi3[i].toInt()//uuid ye ulaştık modemdeki idleri eşledik
            i = i   1
        }
        arama.value?.let { aramalariGoster(it) }
    }
    ozelSharedPrefences.zamaniKaydet(System.nanoTime())
}

}

and this is my detail page fragment codes:

class DetaySayfasi : Fragment() {

private lateinit var viewModel : MovieDetayiViewModel
private lateinit var viewModel2: MovieListesiViewModel
var movieId : Int = 0
var getId : String =""
var listeIdAlma : Int = 0
private val ozelSharedPrefences2 = OzelSharedPrefences()


override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)

}
override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
    // Inflate the layout for this fragment
    return inflater.inflate(R.layout.fragment_detay_sayfa, container, false)

}
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
    super.onViewCreated(view, savedInstanceState)
    viewModel2 = ViewModelProviders.of(this).get(MovieListesiViewModel::class.java)
    viewModel2.refreshData()
    arguments?.let {
       movieId = DetaySayfasiArgs.fromBundle(it).movieID
    }

    viewModel = ViewModelProviders.of(this).get(MovieDetayiViewModel::class.java)

    viewModel.roomVerisiniAl(movieId)
    observeLiveData2()
    viewModel.roomVerisiniAl2(movieId)
    observeLiveData()
    viewModel.roomVerisiniAl3(movieId)

    dislike.setOnClickListener {
        like()
    }
    like.setOnClickListener {
        dislike()
    }
    observeLiveData3()
    geri()
    uygulamaPaylas()

}
fun observeLiveData(){
    viewModel.movieLiveData.observe(viewLifecycleOwner, Observer { movie->
        movie?.let {
            getId = "movie/" "${it.id}"
            listeIdAlma= it.id
            movie_title.text=it.title
            movie_overview.text= it.overview
            movie_rating_text.text=it.voteAverage.toFloat().toString()
            movie_rating.rating = it.voteAverage.toFloat()/2
            context?.let {
                movie_backdrop.gorselIndir("https://image.tmdb.org/t/p/w500" "${movie.backdropPath}", placeHolderYap(it))
                movie_poster.gorselIndir("https://image.tmdb.org/t/p/w500" "${movie.posterPath}", placeHolderYap(it))
            }
            if (!(listeIdAlma in ozelSharedPrefences2.korku())){
                Log.d("ozelshared","${ozelSharedPrefences2.korku()}")
                Log.d("listetaramaid","${listeIdAlma}")
                like.visibility=View.GONE
                dislike.visibility=View.VISIBLE
            }else{
                like.visibility=View.VISIBLE
                dislike.visibility=View.GONE
                Log.d("else","like kapalı olması lazım")
            }
        }
    })
}
fun observeLiveData2(){
    viewModel.diziLiveData.observe(viewLifecycleOwner, Observer { tv->
        tv?.let {
            getId = "tv/" "${it.id}"
            listeIdAlma = it.id
            movie_title.text=it.name
            movie_overview.text= it.overview
            movie_rating_text.text= it.voteAverage?.toFloat().toString()
            movie_rating.rating = it.voteAverage!!.toFloat()/2
            context?.let {
                movie_backdrop.gorselIndir("https://image.tmdb.org/t/p/w500" "${tv.backdropPath}", placeHolderYap(it))
                movie_poster.gorselIndir("https://image.tmdb.org/t/p/w500" "${tv.posterPath}", placeHolderYap(it))
            }
            if (!(listeIdAlma in ozelSharedPrefences2.korku())){
                Log.d("ozelshared","${ozelSharedPrefences2.korku()}")
                Log.d("listetaramaid","${listeIdAlma}")
                like.visibility=View.GONE
                dislike.visibility=View.VISIBLE
            }else{
                like.visibility=View.VISIBLE
                dislike.visibility=View.GONE
                Log.d("else","like kapalı olması lazım")
            }
        }
    })
}

fun observeLiveData3(){
    viewModel.aramaLiveData.observe(viewLifecycleOwner, Observer { tv->
        tv?.let {
            if (it.voteAverage!=null){
                getId = "tv/" "${it.id}"
                listeIdAlma = it.id!!
                movie_title.text=it.name
                movie_overview.text= it.overview
                movie_rating_text.text= it.voteAverage?.toFloat().toString()
                movie_rating.rating = it.voteAverage?.toFloat()!!/2
                context?.let {
                    movie_backdrop.gorselIndir("https://image.tmdb.org/t/p/w500" "${tv.backdropPath}", placeHolderYap(it))
                    movie_poster.gorselIndir("https://image.tmdb.org/t/p/w500" "${tv.posterPath}", placeHolderYap(it))
                }
            }else{
                getId = "tv/" "${it.id}"
                listeIdAlma = it.id!!
                movie_title.text=it.name
                movie_overview.text= it.name
                movie_rating_text.text= ""
                movie_rating.rating = 10F
                context?.let {
                    movie_backdrop.gorselIndir("https://image.tmdb.org/t/p/w500" "${tv.profile_path}", placeHolderYap(it))
                    movie_poster.gorselIndir("https://image.tmdb.org/t/p/w500" "${tv.profile_path}", placeHolderYap(it))
                }
            }
            if (!(listeIdAlma in ozelSharedPrefences2.korku())){
                Log.d("ozelshared","${ozelSharedPrefences2.korku()}")
                Log.d("listetaramaid","${listeIdAlma}")
                like.visibility=View.GONE
                dislike.visibility=View.VISIBLE
            }else{
                like.visibility=View.VISIBLE
                dislike.visibility=View.GONE
                Log.d("else","like kapalı olması lazım")
            }
        }
    })
}

Like I said if I delete my one of recycler view its working perfect but if I use two recycler on same fragment I got wrong datas. Logs says I open correct data but it's not. If u need my other codes to solve problem say it please I have lots of screens don't know which one I need to share to solve it.

CodePudding user response:

i solved my problem but i don't know what i changed on background i just seperate my one function to two function in MovieListesiViewmodel and gave a parameter and its worked like a miracle

 private fun verileriInternettenAl(denemeInt: Int){
    filmYukleniyor.value = true
    disposable.add(
       filmApiServis.getData(denemeInt)
            .subscribeOn(Schedulers.newThread())
            .observeOn(AndroidSchedulers.mainThread())
            .subscribeWith(object: DisposableSingleObserver<GetMoviesResponse>(){
                override fun onSuccess(t: GetMoviesResponse) {
                    filmler.value= t.results
                    filmHataMesaji.value=false
                    filmYukleniyor.value=false
                    sqliteSakla(t.results)
            //        Toast.makeText(getApplication(),"Filmler internetten yüklendi",Toast.LENGTH_LONG).show()
                }
                override fun one rror(e: Throwable) {
                    filmHataMesaji.value=true
                    filmYukleniyor.value=false
                    e.printStackTrace()
                }
            })
    )
}
fun verileriInternettenAl2(){
    disposable2.add(
        filmApiServis.getVizyondakiler()
            .subscribeOn(Schedulers.newThread())
            .observeOn(AndroidSchedulers.mainThread())
            .subscribeWith(object: DisposableSingleObserver<NowPlaying>(){
                override fun onSuccess(t: NowPlaying) {
                    dizi.value= t.results
                    filmHataMesaji.value=false
                    filmYukleniyor.value=false
                    diziSqLiteSakla(t.results)
                }
                override fun one rror(e: Throwable) {
                    filmHataMesaji.value=true
                    filmYukleniyor.value=false
                    e.printStackTrace()
                }
            })
    )
}
  • Related