Home > OS >  Filtering an array with a loop not working
Filtering an array with a loop not working

Time:03-19

I don't see what the problem is. The same type of code worked fine for something similar before (jsfiddle https://jsfiddle.net/Montinyek/ufkdgz4t/3/), but now it just gives a strange error. Can someone please explain why this method worked for the jsfiddle example but not here?

let story = 'Last weekend, I took literally the most beautiful bike ride of my life. The route is called "The 9W to Nyack" and it actually stretches all the way from Riverside Park in Manhattan to South Nyack, New Jersey. It\'s really an adventure from beginning to end! It is a 48 mile loop and it basically took me an entire day.

let unnecessaryWords = ['extremely', 'literally', 'actually' ];
const betterWords = []
const storyWords = story.split(' ')

for(let i = 0; i < storyWords.length; i  ) {
  for(let j = 0; j < unnecessaryWords.length; j  ) {
    if (storyWords[i] !== unnecessaryWords[j]) {
      betterWords.push(storyWords)
    }
  }
}

I also tried using the splice() method, again with weird results:

for(let i = 0; i < storyWords.length; i  ) {
  for(let j = 0; j < unnecessaryWords.length; j  ) {
    if (storyWords[i] === unnecessaryWords[j]) {
      betterWords.push(storyWords.splice(unnecessaryWords[j], 1))
    }
  }
} 

CodePudding user response:

As you mentioned there are other ways to achieve this. Here is one of them.

let story = 'Last weekend, I took literally the most beautiful bike ride of my life. The route is called "The 9W to Nyack" and it actually stretches all the way from Riverside Park in Manhattan to South Nyack, New Jersey. It\'s really an adventure from beginning to end! It is a 48 mile loop and it basically took me an entire day.';

let unnecessaryWords = ['extremely', 'literally', 'actually' ];

const storyWords = story.split(' ')

const betterWords = storyWords.filter(sw => !unnecessaryWords.includes(sw));

console.log(betterWords);

CodePudding user response:

You can create a variable which keeps track of whether the particular storyWord was found in unnecessaryWords, and only push the storyWord to betterWords if it's false.

let story = 'Last weekend, I took literally the most beautiful bike ride of my life. The route is called "The 9W to Nyack" and it actually stretches all the way from Riverside Park in Manhattan to South Nyack, New Jersey. It\'s really an adventure from beginning to end! It is a 48 mile loop and it basically took me an entire day.';

let unnecessaryWords = ['extremely', 'literally', 'actually' ];
const betterWords = []
const storyWords = story.split(' ')

for(let i = 0; i < storyWords.length; i  ) {
  let foundInUnnecessary = false;
  for(let j = 0; j < unnecessaryWords.length; j  ) {
    if (storyWords[i] === unnecessaryWords[j]) {
      foundInUnnecessary = true;
      break;
    }
  }
  if (!foundInUnnecessary) {
    betterWords.push(storyWords[i]);
  }
}

console.log(betterWords);

  • Related