Terraform ECS Task Definition jsonencode issue-CodePudding

I get this error when applying terraform. It's clearly something wrong with my env_Vars. I've tried making name and value in quotes or without.

Error: ECS Task Definition container_definitions is invalid: Error decoding JSON: json: cannot unmarshal number into Go struct field KeyValuePair.Environment.Value of type string

locals:

locals {
  task_name = "${var.project_name}-${var.environment}-pgadmin"
  env_vars = [
    {
      name  = "ENV",
      value = var.environment
    },
    {
      name  = "POSTGRES_HOST",
      value = module.rds.db_address
    },
    {
      name  = "POSTGRES_USER",
      value = module.rds.db_username
    },
    {
      name  = "POSTGRES_PORT",
      value = module.rdsdb_port
    }
  ]
}

task def template:

data "template_file" "task-definition" {

template = file("${path.module}/container_definition_template.json.tpl")

  vars = {
    container_name        = local.task_name
    container_image       = "dpage/pgadmin4"
    container_port        = 3001
    env_variables         = jsonencode(local.env_vars)
    secrets               = jsonencode(local.secrets)
  }
}

Task def:

resource "aws_ecs_task_definition" "pgadmin_task_definition" {
  family                = local.task_name
  container_definitions = data.template_file.task-definition.rendered
  task_role_arn         = aws_iam_role.ecsTaskRole.arn

  network_mode             = "awsvpc"
  cpu                      = 1024
  memory                   = 2048
  requires_compatibilities = ["FARGATE"]
  execution_role_arn       = aws_iam_role.ecsTaskExecutionRole.arn
}

actual json template is :

 [
  {
    "name": "${container_name}",
    "image": "${container_image}",
    "startTimeout": 120,
    "logConfiguration": {
      "logDriver": "awslogs",
      "options": {
        "awslogs-group": "${aws_logs_group}",
        "awslogs-region": "${aws_region}",
        "awslogs-stream-prefix": "${aws_log_stream_prefix}"
      }
    },
    "environment": ${env_variables},
    "secrets": ${secrets},
    "portMappings": [
      {
        "containerPort": ${container_port},
        "hostPort": ${container_port}
      }
    ]
  }
]

CodePudding user response：

I think this happens becuase module.rdsdb_port is number in local.env_vars, not string. You can try with:

      value = tostring(module.rdsdb_port)